Are you doing it right? Well, yes. Yes you are, as far as I can tell. I don't see anything that would be considered 'wrong'. In fact, you look very well put together, especially for a self-proclaimed newbie! Jock's advice, as well as Matt's, are simply style suggestions, and I have a few of my own to add.

Firstly, I'm one of those who Jock Scot has gently guided into the territory of wearing tattersal shirts, striped ties, and other non-matchy patterns that are difficult for us Americans to wrap our minds around. I'm absolutely a lost cause now; I can't go back to wearing plain shirts and plain ties, especially not together. The patterns lend a depth or complexity to the look that's just wonderful as well as traditional.

Another style suggestion - again, reiterating that there's absolutely nothing 'wrong' with what you're currently wearing - would be to find some shoes that are less 'chunky'. Both the shoes you're wearing have very thick soles and fat, rounded toes. But if you look closely at photos of native Scots wearing traditional Highland dress, as well as historical photos and portraits, you'll see that they tend to wear thinner shoes that don't accentuate the feet. It's a proportion thing (I seem to be stuck lately on fine-tuning things with respect to overall proportions). Shoes which look narrower and longer, with thinner soles, really bring the rest of the outfit into proportion, regardless of your actual body proportions.

If it were me, I'd also bring the tops of the hose down just a smidge, using the typical "three finger" rule below the kneecap, or trying to keep it just over the widest part of the calf and no higher. This is also a proportion thing. It makes a big difference in the overall look. It appears that your hose are House of Cheviot, though the resolution isn't good enough to tell which style. And I know they tend to run long, with a big seam, making it difficult to shorten them at the top.

And speaking of hose, it would also look smashing if you were to ditch the flashes in favour of traditional woollen self-tie garters. Again, just a style thing. Nothing wrong with flashes, and actually most Scots do wear flashes rather than garters. But the garters just seem to have a better look, with some complexity to the fringed ends instead of the clean aerodynamic look of flashes.

I agree with Jock's comment on the tie knot too. Again - proportions! The knot you've chosen (which can also be a function of the width of the tie and the fact that you're tying it short for wearing with a kilt) looks very wide, and can have large effects on the overall proportions of your upper body, neck, shoulders, etc. Maybe a narrower tie, or a different knot that has a narrower profile might change the proportions. Experiment and find what you like best, keeping proportions in mind.

Overall, though, you still look great as-is. Better than 95% of the rest of the crowd you'll see, anyway!