I have always thought they should be diagonal and that is based on the fact that on several jackets I owned the buttons had images that were right side up when the button was diagonal to the level. I have had buttons where it wouldn't matter either way as well, but I have never had any buttons with images that only looked correct with the buttons square to level.