Having just returned home from a 3 week vacation in Scotland, I can confirm, as P1M says, that it is very uncommon to see the kilt worn as 'everyday' attire - I think I noticed only 3 others.

I received many positive comments, only one nasty one.
I lost count of how many times I was asked if I was a true Scotsman.
Safe answer - 'No, I am Canadian'.

My visit to Edinburgh Castle took a bit longer than expected, since a crowd would gather 'round me, waiting for the guided tour to begin.

Lee