Local Hero is near the top, as is That Sinking Feeling, but the top Scots film for me has to be Gregory's Girl. My DVD even comes with an American dubbed soundtrack for those who have trouble with Scottish!