About the identification of the regiment portrayed in the movie:

I recently rented the movie from Netflix, and the DVD contained several extras, including a long conversation with the director, I think, Ronald Neame.

There's quite a wealth of information on the making of the movie in that short, but specific to which regiment it is, I remember the director saying several telling things. Most importantly, that they had wanted to film at the Argylls' castle barracks, (and then his making a parenthetical comment to the effect that that was the regiment they wanted to portray, or something to that effect), and had set a meeting after having a favorable response to several officers' reading the screenplay the movie-makers had sent over for review.

They showed up at the meeting the next day and entered the CO's office to find the mood had changed, and they could see instantly why: on the CO's desk, there was a copy of a paperback reprint of Kennaway's novel, and on the cover the publisher had put a still shot of Alec Guinness (Jock Sinclair) in uniform with Kay Walsh (Mary Titterington) on his lap. The story went on that the CO was not pleased, but the film-makers eventually were able to get him to agree to let them film at the barracks on the condition that they alter the roofline of the castle in post production using a matte so that the easily identifiable roofline would not be recognized.

I returned the movie a couple of weeks ago (after grabbing a couple of still shots for helping to identify what I now think is the 1951 pattern greatcoat*...anyone know where I can get one?), but if you're on Netflix, put it in your queue if only for the DVD extras -- there's a conversation (audio-only) with John Mills and Alec Guinness (didn't watch it, so don't know if it's video or similarly audio-only), as well as the informative director interview mentioned above.

*
Quote Originally Posted by kilted_brewer View Post
Here's a shot of Alec Guinness as Jock Sinclair in Tunes of Glory in his greatcoat (photo lightened to show off the greatcoat: the shot in the film is really dark)